Add notModified method to HTTP client (#48379)

laravel · Sep 13, 2023 · ece34f1 · ece34f1
1 parent 5f78beb
commit ece34f1
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/Illuminate/Http/Client/Concerns/DeterminesStatusCode.php b/src/Illuminate/Http/Client/Concerns/DeterminesStatusCode.php
@@ -65,6 +65,16 @@ public function found()
         return $this->status() === 302;
     }
 
+    /**
+     * Determine if the response code was a 304 "Not Modified" response.
+     *
+     * @return bool
+     */
+    public function notModified()
+    {
+        return $this->status() === 304;
+    }
+
     /**
      * Determine if the response was a 400 "Bad Request" response.
      *

diff --git a/tests/Http/HttpClientTest.php b/tests/Http/HttpClientTest.php
@@ -52,6 +52,8 @@ protected function setUp(): void
     protected function tearDown(): void
     {
         m::close();
+
+        parent::tearDown();
     }
 
     public function testStubbedResponsesAreReturnedAfterFaking()
@@ -133,6 +135,20 @@ public function testFoundRequest()
         $this->assertFalse($response->found());
     }
 
+    public function testNotModifiedRequest(): void
+    {
+        $this->factory->fake([
+            'vapor.laravel.com' => $this->factory::response('', HttpResponse::HTTP_NOT_MODIFIED),
+            'forge.laravel.com' => $this->factory::response('', HttpResponse::HTTP_OK),
+        ]);
+
+        $response = $this->factory->post('https://vapor.laravel.com');
+        $this->assertTrue($response->notModified());
+
+        $response = $this->factory->post('https://forge.laravel.com');
+        $this->assertFalse($response->notModified());
+    }
+
     public function testBadRequestRequest()
     {
         $this->factory->fake([