CommandStarted and CommandFinished no longer testable in PhpUnit

[henzeb]

• Laravel Version: 10.4.1
• PHP Version: 8.2.4
• Database Driver & Version: -

Description:

I traced it back to this pull request which was about memory leaks, but now it does no longer dispatch the Events when running from phpunit.

That is because of the if statement around it.

framework/src/Illuminate/Foundation/Console/Kernel.php

Lines 121 to 123 in 485f223

	if (! $this->app->runningUnitTests()) {
	$this->rerouteSymfonyCommandEvents();
	}

This was possible in earlier versions of Laravel, so this is definitely a breaking change.

Steps To Reproduce:

the following test will succeed in earlier versions of laravel:

public function testFailingCommandEvents()
{
      $actual = false;
      
      Event::listen(CommandStarting::class, function () use (&$actual) {
          $actual = true;
      });

      Artisan::command(
          'myApplication',
          function () {
          }
      );

      Artisan::call('myApplication');

      $this->assertTrue($actual);
}

[crynobone]

Add the following command if you want to test command events:

$this->app[\Illuminate\Contracts\Console\Kernel::class]->rerouteSymfonyCommandEvents();

[henzeb]

Add the following command if you want to test command events:

$this->app[\Illuminate\Contracts\Console\Kernel::class]->rerouteSymfonyCommandEvents();

Its a good work around, but I still consider this a breaking change.

[crynobone]

Current

If we revert the changes

Memory usage increased by more than 500MB

---

If we want to revert it then both #46508 and #46442 should be reverted.

[henzeb]

so you say, that if we JUST remove the if($app->runningUnitTests()) statement, we have a memoryleak?

[crynobone]

yes

[henzeb]

Weird. will it be mentioned in the docs? because it took me all day to figure out it was laravel and not my changes in my project.

[driesvints]

I'm sorry you got caught by this. But given the fact that the above PR solves a significant memory leak we won't be reverting this. Since probably very people are using/relying on this we'll not mention this anywhere explicitly.