[10.x] Fix parsed input arguments for command events using dispatcher rerouting #46442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bert-w
commented
Mar 12, 2023
| $dispatcher = new EventDispatcher(); | ||
| $this->setDispatcher($dispatcher); | ||
|
|
||
| $dispatcher->addListener(ConsoleEvents::COMMAND, function (ConsoleCommandEvent $event) { |
There was a problem hiding this comment.
optionally this can be changed to $dispatcher->addSubscriber(...) and move this logic to a separate class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for #46430 where a Symfony dispatcher is created for
\Illuminate\Console\Applicationin order to reroute the events to the Laravel counterpart. This has the benefit that theInputis properly bound to the command definition, and it is thus available in the event itself.The complete
\Illuminate\Console\Application::run()override has been removed.This opens up the possibility to add some more events as well:
\Symfony\Component\Console\ConsoleEvents::COMMAND\Illuminate\Console\Events\CommandStarting, included in PR)\Symfony\Component\ConsoleConsoleEvents::TERMINATE\Illuminate\Console\Events\CommandFinished, included in PR)\Symfony\Component\Console\ConsoleEvents::SIGNAL\Symfony\Component\Console\ConsoleEvents::ERROR