[5.5] Fix SQLiteGrammar whereTime method with correct formatting #23408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strftime('time', created_at)is not working for sqlite and we need to apply correct formatting%H:%M:%S.It also should be merged to 5.6 and master branches.
You can read more about sqlite date functions here: https://www.sqlite.org/lang_datefunc.html
PR #23321 was successfully merged to 5.6. But it's a bug and should be merged to current LTS version 5.5.
It's a copy of #23316. As I can see, the only way to make an attention is to re-open PR as @sisve suggests.