Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[10.x] add Storage::json() method to read and decode a json file" #46553

Closed
wants to merge 1 commit into from
Closed

Revert "[10.x] add Storage::json() method to read and decode a json file" #46553

wants to merge 1 commit into from
+2 −31

Conversation

driesvints
Copy link
Member

Reverts #46548

This PR changes the sequence of parameters of the json method and thus causing a breaking change for anyone using the lock param.

@lorenzolosa
Copy link
Contributor

I see your point, but I would suggest reverting only the addition of the $flags parameter instead of the whole PR.

@taylorotwell
Copy link
Member

This hasn't been documented or released yet.

@taylorotwell taylorotwell deleted the revert-46548-storage_json branch March 23, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driesvints @lorenzolosa @taylorotwell