Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Add Precognition-Success header #47081

Merged
merged 1 commit into from
May 15, 2023

Conversation

timacdonald
Copy link
Member

This PR introduces an additional header to indicate that Precognition was successful.

Currently, we always return the Precognition: true header for any request that is precogntive.

We also currently return a 204 No Content response when Precognition is considered "Successful".

We use these two indicators to currently detect when a precogntive request is successful.

However, it is possible for a precognitive request to receive a 204 No Content response, via say a user-land middleware, that does not indicate that Precognition was actually successful, i.e., reached the "end of the line" before the controller method.

With the addition of this header, we have a guaranteed way to detect "successful" precognition requests.

This is not a breaking change and the other precognition header is still useful.

Copy link
Member

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear for me the changes on this pull request. So, going to let Taylor to fully validate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants