Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Use shared facade script #47901

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Jul 31, 2023

This PR migrates the framework to use the shared facade script, rather than storing it in the framework itself. We use the shared script on a couple of our packages. We currently have to keep changes in sync.

The shared script includes some improvements to return types that reference static and self. This will fix 2 issues within the framework.

All changes from the framework script already exist in the shared script.

Comment on lines +21 to +22
with:
fetch-depth: 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taylorotwell taylorotwell merged commit 2373c83 into laravel:10.x Jul 31, 2023
19 checks passed
@timacdonald timacdonald deleted the facades branch July 31, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants