Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Fix type error registering PSR Request #48823

Merged
merged 3 commits into from
Oct 26, 2023
Merged

[10.x] Fix type error registering PSR Request #48823

merged 3 commits into from
Oct 26, 2023

Conversation

kpicaza
Copy link
Contributor

@kpicaza kpicaza commented Oct 25, 2023

Type error at Illuminate\Routing\RoutingServiceProvider::registerPsrRequest

Fixes #48822

@timacdonald timacdonald self-assigned this Oct 25, 2023
@timacdonald timacdonald marked this pull request as draft October 25, 2023 22:22
@timacdonald timacdonald marked this pull request as ready for review October 25, 2023 22:38
timacdonald
timacdonald approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@timacdonald timacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the type error fix but also that it was previously expecting to have an empty array as the parsed body and not null.

LGTM.

@taylorotwell taylorotwell merged commit d5e8a9d into laravel:10.x Oct 26, 2023
20 checks passed
@timacdonald timacdonald mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timacdonald timacdonald timacdonald approved these changes

Assignees

@timacdonald timacdonald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError in Illuminate\Routing\RoutingServiceProvider::registerPsrRequest
3 participants
@kpicaza @timacdonald @taylorotwell