[10.x] Use HtmlString in Vite fake #49163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #49150 has started to break our test suite.
Since that PR, the faked Vite instance now implements
Htmlable
, so we're now seeing a lot ofCall to member function toHtml() on string
from this line:framework/src/Illuminate/Foundation/Vite.php
Line 784 in 1e03a4a
Since
toHtml()
is expecting__invoke
to return anHtmlString
, that's what this PR is doing.We don't use the
@vite
directive (the error doesn't happen if you do). We use the facade essentially like this:For the test I just slapped on
->toHtml()
the same way you do that in https://github.com/laravel/framework/blob/10.x/tests/Foundation/FoundationViteTest.php