Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Accept the length of the secret key 🔐 #49282

Closed
wants to merge 1 commit into from
Closed

[10.x] Accept the length of the secret key 🔐 #49282

wants to merge 1 commit into from

Conversation

mahmoudmohamedramadan
Copy link
Contributor

@mahmoudmohamedramadan mahmoudmohamedramadan commented Dec 8, 2023

This PR adds more flexibility and difficulty to the merged #49171 PR where we can pass the length of the secret key that we wish to generate via the next artisan command

php artisan down --with-secret=32

This command should generate the next output

Note

Application is now in maintenance mode.
You may bypass maintenance mode via [http://localhost/OSv41HY6bYiN8TkbuiKL09G3lMlOTBmw]

@jj15asmr
Copy link
Contributor

jj15asmr commented Dec 9, 2023

I appreciate you extending my PR but I'm not sure I like this change as it would now require the user to define a length for the generated secret which makes it a breaking change. Also, in my opinion, the purpose of --with-secret is to help the user save time by not having to define anything about the secret.

@mahmoudmohamedramadan
Copy link
Contributor Author

I agree with you, but the purpose of this PR is to add more flexibility to your idea. In addition, it's not a BC as it's not a function that is not used by many projects it is just an option which it's not affect anything, where the developer can pass this option such --with-secret=16 like the default procedure.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants