Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incomplete type for Builder::from property #50426

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix: incomplete type for Builder::from property #50426

merged 2 commits into from
Mar 8, 2024

Conversation

sebj54
Copy link
Contributor

@sebj54 sebj54 commented Mar 8, 2024

Hi,

I fixed an incorrect type in Illuminate\Database\Builder. PHPStan is showing a warning when I'm checking the from property of my Builder is an Expression.

You can see here that it can be an expression:

$this->from = new Expression($expression);

@taylorotwell taylorotwell merged commit a03b17c into laravel:10.x Mar 8, 2024
18 of 19 checks passed
@sebj54 sebj54 deleted the patch-1 branch March 8, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants