Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Add "Server has gone away" to DetectsLostConnection #51241

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Apr 29, 2024

Closes #51229

@taylorotwell taylorotwell merged commit 236ee6d into laravel:10.x Apr 29, 2024
26 checks passed
@Jubeki Jubeki deleted the patch-5 branch April 29, 2024 13:29
@dennisprudlo
Copy link
Contributor

@Jubeki out of curiosity, is case sensitivity necessary here? Would lowercasing the message also be an option or is it better to be explicit in case the same message in a different case means something completely different for some reason?

@driesvints
Copy link
Member

Yes casing is important here. See the linked issue.

@dennisprudlo
Copy link
Contributor

dennisprudlo commented May 1, 2024

@driesvints yes, what I meant was that the fix was necessary because the error message is being transformed to "uppercase the first character" by an sql engine or a hosting provider. If another provider returns the message in say title case or the same provider uses this logic for other messages as well, another update will be necessary.

Can't this be simplified by lowercasing the strings before checking (this wouldn't require redundant messages)? Or is this too risky?

@driesvints
Copy link
Member

@dennisprudlo I'm not sure myself. Your idea sounds good to me tbh. We could maybe try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants