[11.x] Add make:job-middleware artisan command

[dshafik]

This PR adds a new make:job-middleware artisan command that will create a new Job Middleware class in App\Jobs\Middleware. This stub is based on the docs.

One other minor change is to update the description for make:middleware to clarify it creates HTTP middleware.

An alternative to this would be to add --job flag to make:middleware that will conditionally create a Job middleware instead of HTTP middleware (could also add a corresponding --http flag just for completeness sake) — let me know if that is preferred.

[devajmeireles]

That's cool, but I'm wondering if we can't simply adapt make:middleware to ask what kind of middleware we want to create?

[dshafik]

That's cool, but I'm wondering if we can't simply adapt make:middleware to ask what kind of middleware we want to create?

That's what I suggested as an alternative in the PR description (make:middleware --job). My main concern is that the MiddlewareMakeCommand is in the \Illuminate\Routing\Console namespace where the Job middleware stuff arguably does not belong. Are there any other commands that cross multiple concerns like this?

[devajmeireles]

That's cool, but I'm wondering if we can't simply adapt make:middleware to ask what kind of middleware we want to create?

That's what I suggested as an alternative in the PR description (make:middleware --job). My main concern is that the MiddlewareMakeCommand is in the \Illuminate\Routing\Console namespace where the Job middleware stuff arguably does not belong. Are there any other commands that cross multiple concerns like this?

Although you're right, you can still implement this logic if you check if something related to queues was loaded, for example the ShouldQueue interface. If yes, you can display a selection - to select the middleware type, after insert the middleware name in the make:middleware command.

[dshafik]

@devajmeireles what are you thinking of checking for the ShouldQueue interface? During the execution of the artisan command there are no jobs loaded or anything…

[devajmeireles]

@devajmeireles what are you thinking of checking for the ShouldQueue interface? During the execution of the artisan command there are no jobs loaded or anything…

You had mentioned: "MiddlewareMakeCommand is in the \Illuminate\Routing\Console namespace where the Job middleware stuff arguably does not belong.". To resolve this, you can check if something related to queues exists - I used ShouldQueue as an example, if it does then we can generate a middleware for jobs using make:middleware.