[1.x] Gracefully handles unexpected null
scope
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gracefully handles
null
scope when a feature definition / resolver has a non-nullable type declaration.Instead of throwing a type exception when checking if the feature is active, we will now return
false
and dispatch theLaravel\Pennant\Events\UnexpectedNullScopeEncountered
event.This is a sensible default and is functionality already present in Laravel Authorisation Guards.
If an app wants to opt-out of this behaviour: