-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#221 - Switch to async/await and major Lasso refactors #222
Conversation
I'm glad you didn't have to change many files :) |
I agree -- good time to start discussing rename. |
Also, maybe in future PR, switch to using |
Did you verify error handling with a outermost |
As a follow-up, I want to actually revisit a lot of this code and refactor. This would include |
To summarize the changes:
lasso-image
,lasso-resolve-css-urls
,lasso-minify-css
,lasso-minify-js
have all been moved into Lasso.The functional changes resulted in ~1500 lines of code reduction
I split the PR into 3 main commits. One that has most of the functional changes, the second that contains the external Lasso modules being pulled into core, and the 3rd being eslint fixes.
Most of the functional changes are in this commit: b7d65ac
Ultimately, I think this may be a good time to change the name of Lasso to something else. These changes are major breaking and will only support Node 8+.