Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:tzdata_release_updater terminating. 2nd argument: not a tuple #148

Closed
instancer-kirik opened this issue Sep 10, 2024 · 9 comments
Closed

Comments

@instancer-kirik
Copy link

[debug] Tzdata data downloaded. Release version 2024b.
[error] GenServer :tzdata_release_updater terminating
** (ArgumentError) errors were found at the given arguments:

  * 2nd argument: not a tuple

    :erlang.element(1, :error)
    (tzdata 1.1.1) lib/tzdata/util.ex:223: Tzdata.Util.to_int/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:38: Tzdata.Parser.process_rule/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:86: Tzdata.Parser.process_zone/5
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:86: Tzdata.Parser.process_zone/5
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:86: Tzdata.Parser.process_zone/5
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:86: Tzdata.Parser.process_zone/5
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:86: Tzdata.Parser.process_zone/5
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:86: Tzdata.Parser.process_zone/5
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:86: Tzdata.Parser.process_zone/5
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
    (tzdata 1.1.1) lib/tzdata/parser.ex:86: Tzdata.Parser.process_zone/5
    (tzdata 1.1.1) lib/tzdata/parser.ex:24: Tzdata.Parser.process_tz_list/1
Last message: :check_if_time_to_update
State: []

I did start off with my config as
config :tzdata, :data_dir, "priv/tzdata"
which also had this error on mix phx.server
and is now

config :tzdata, :autoupdate, :disabled # Disable automatic updates of tzdata because crashy
config :elixir, :time_zone_database, Tzdata.TimeZoneDatabase
config :tzdata, :data_dir, "priv/tzdata"
@treshenry
Copy link

Yep, just saw the same after updating.

[error] GenServer :tzdata_release_updater terminating
** (ArgumentError) errors were found at the given arguments:

  * 2nd argument: not a tuple

    :erlang.element(1, :error)
    (tzdata 1.1.1) lib/tzdata/util.ex:223: Tzdata.Util.to_int/1

@namxam
Copy link

namxam commented Sep 10, 2024

It seems this have been an issue which is marked as resolved, but isn't. From what I understood by a quick glance, the source data might have changed and causes issues. #143

@lau
Copy link
Owner

lau commented Sep 10, 2024

@namxam Is this after upgrading to tzdata v1.1.2 ?

@namxam
Copy link

namxam commented Sep 10, 2024

Honestly I don't know, because the error is handled gracefully. I just noticed it in a project I am not working on often. I know I updated a few dependencies but I am not sure if tzdata was among it. I will check when I am back at my computer.

@barttenbrinke
Copy link

Was greeted with the same error this morning, Upgrading from tzdata 1.1.1 => 1.1.2 fixed this for me.

@chauhan471
Copy link

Was greeted with the same error this morning, Upgrading from tzdata 1.1.1 => 1.1.2 fixed this for me.

Thanks it saved me some time.

@treshenry
Copy link

I think the tzdata dep in our project is actually coming from here: https://github.com/bitwalker/timex/blob/c45b9a734074ac2a56355ec52ebf931b932223b7/mix.exs#L58. Our lock file says 1.1.1 so I'll update and see if that resolves it.

@lau
Copy link
Owner

lau commented Sep 11, 2024

This should be fixed in the v1.1.2 release: e63fc28

@treshenry
Copy link

Woot!
image

github-merge-queue bot pushed a commit to etalab/transport-site that referenced this issue Sep 17, 2024
* Bump tzdata

See: lau/tzdata#148

* Remove left-over :focus tags

* Re-introduce test for #3820

It will catch the issue at least locally. But CI must likely be fixed to detect it.

* Add temporary printf debugging (TM) to try to figure out the lack of failure on CI

* Verify the destiny of the lock file (likely modified)

* Implement a CI-reproduction for #3820

* Fix regression (#3820)

Co-authored-by: Antoine Augusti <antoine.augusti@transport.data.gouv.fr>

---------

Co-authored-by: Antoine Augusti <antoine.augusti@transport.data.gouv.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants