Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Adds feature enabling Rustls usage rather than OpenSSL #1584

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

SonicZentropy
Copy link
Contributor

Pretty simple Cargo change to allow the CLI to use Rustls instead. It still defaults to native-tls, so should be transparent to users!

sqlx-cli/Cargo.toml Outdated Show resolved Hide resolved
Removes extraneous openssl feature that slipped through

Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
@SonicZentropy
Copy link
Contributor Author

Quite correct, sorry! I threw that in last-second to make sure it did NOT break, then forgot to remove it again

@abonander
Copy link
Collaborator

abonander commented Dec 22, 2021

For the instructions to still be correct about $ cargo install sqlx-cli --features openssl-vendored, the openssl-vendored feature should also enable the native-tls feature.

@abonander abonander changed the title Adds feature enabling Rustls usage rather than OpenSSL [CLI] Adds feature enabling Rustls usage rather than OpenSSL Dec 27, 2021
@abonander
Copy link
Collaborator

@SonicZentropy have you seen my previous comment?

@abonander
Copy link
Collaborator

Nevermind sorry, I didn't realize the install instructions didn't include --no-default-features there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants