Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all ConnectOptions clonable #1612

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

05storm26
Copy link
Contributor

@05storm26 05storm26 commented Jan 6, 2022

Currently all ConnectOptions implementation are Clone. I think this will continue to be true, and it might be useful to give this guarantee in general.

@05storm26
Copy link
Contributor Author

05storm26 commented Jan 6, 2022

(I think, this will need to be rebased after #1610 and needs a simple conflict resolve)

@05storm26 05storm26 force-pushed the clonable_connect_options branch 2 times, most recently from e4b2eae to 63685d0 Compare January 6, 2022 08:56
@05storm26
Copy link
Contributor Author

@abonander When can you merge this? Is this going to be in 0.6?

@abonander abonander added this to the 0.6.0 milestone Feb 17, 2022
@05storm26
Copy link
Contributor Author

I rebased this on master and resolved the conflict

@abonander abonander merged commit a68957b into launchbadge:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants