Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query_as: don't stop stream after decoding error #1887

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented May 31, 2022

Fixes #1884

When a single row cannot be converted to the target type of query_as,
it should not prevent the library user from accessing the other rows

Otherwise, the user cannot access all query results in query_as.

Fixes launchbadge#1884

When a single row cannot be converted to the target type of query_as,
it should not prevent the library user from accessing the other rows

Otherwise, the user cannot access all query results in query_as.
@lovasoa lovasoa changed the title Fix-1884 query_as: don't stop stream after decoding error May 31, 2022
@lovasoa
Copy link
Contributor Author

lovasoa commented Jun 1, 2022

My new test was failing for postgres, I fixed it.

@abonander abonander merged commit 20d61f4 into launchbadge:master Jun 2, 2022
@lovasoa
Copy link
Contributor Author

lovasoa commented Jun 2, 2022

Thanks !

@lovasoa lovasoa deleted the fix-1884 branch June 2, 2022 08:10
@lovasoa
Copy link
Contributor Author

lovasoa commented Jun 7, 2022

Do you have an idea when this could be released ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

result stream stops after the first decoding error
2 participants