Fix sqlite update return and order by type inference #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
tyrelr
force-pushed
the
fix-sqlite-update-return
branch
from
9582d65
to
269b0c5
Compare
|
Hopefully a rebase will fix the CI failures. |
tyrelr
force-pushed
the
fix-sqlite-update-return
branch
from
269b0c5
to
7e29be3
Compare
|
This would close #1923 right? Unfortunately any change to null inference would be a breaking change so this will have to wait for 0.7.0. Fortunately we don't plan for the 0.6.x release cycle to be as long as 0.5.x, though I don't want to give a concrete timeline since things always change. |
|
Yep, it fixes #1923 (which impacts the calculated nullability). |
tyrelr
changed the title
tyrelr
changed the title
|
PR target changed to the 0.7 development branch. |
Merged
abonander
pushed a commit
that referenced
this pull request
Feb 18, 2023
* add failing test cases for update/delete return into * fix regression in null tracking by improving tracking of cursor empty/full state * add failing test case for order by column types * Add support for SorterOpen,SorterInsert,SorterData * add failing test case for unions * fix range copy/move implementation * fix wrong copy/move range * remove calls to dbg!
abonander
pushed a commit
that referenced
this pull request
Feb 21, 2023
* add failing test cases for update/delete return into * fix regression in null tracking by improving tracking of cursor empty/full state * add failing test case for order by column types * Add support for SorterOpen,SorterInsert,SorterData * add failing test case for unions * fix range copy/move implementation * fix wrong copy/move range * remove calls to dbg!
Aandreba
pushed a commit
to Aandreba/sqlx
that referenced
this pull request
Mar 31, 2023
* add failing test cases for update/delete return into * fix regression in null tracking by improving tracking of cursor empty/full state * add failing test case for order by column types * Add support for SorterOpen,SorterInsert,SorterData * add failing test case for unions * fix range copy/move implementation * fix wrong copy/move range * remove calls to dbg!
tyrelr
added a commit
to tyrelr/sqlx
that referenced
this pull request
Feb 18, 2024
tyrelr
added a commit
to tyrelr/sqlx
that referenced
this pull request
Apr 20, 2024
abonander
pushed a commit
that referenced
this pull request
May 31, 2024
* convert logger to output a query graph * avoid duplicating branch paths to shrink output graph * separate different branching paths * include all branches which found unique states * track the reason for ending each branches execution * track the result type of each branch * make edges rely on history index instead of program_id, to avoid errors when looping * add state diff to query graph * drop redundant table info * rework graph to show state changes, rework logger to store state snapshots * show state on the previous operation * gather duplicate state changes into clusters to reduce repetition * draw invisible connections between unknown instructions by program_i * clean up dot format string escaping * add test case from #1960 (update returning all columns) * add tests for #2939 (update returning only the PK column) * allow inserting into a table using only the index * improve null handling of IfNull, fix output type of NewRowId * add NoResult nodes for branches which don't log a result, as a sanity check * add short-circuit to all logging operations * remove duplicate logging checks, and make logging enabled/disabled consistently depend on sqlx::explain instead of sqlx for capture & sqlx::explain for output * add failing test for awkwardly nested/filtered count subquery * handle special case of return operation to fix failing test * require trace log level instead of using whatever log level statement logging was configured to use
jayy-lmao
pushed a commit
to jayy-lmao/sqlx
that referenced
this pull request
Jun 6, 2024
* convert logger to output a query graph * avoid duplicating branch paths to shrink output graph * separate different branching paths * include all branches which found unique states * track the reason for ending each branches execution * track the result type of each branch * make edges rely on history index instead of program_id, to avoid errors when looping * add state diff to query graph * drop redundant table info * rework graph to show state changes, rework logger to store state snapshots * show state on the previous operation * gather duplicate state changes into clusters to reduce repetition * draw invisible connections between unknown instructions by program_i * clean up dot format string escaping * add test case from launchbadge#1960 (update returning all columns) * add tests for launchbadge#2939 (update returning only the PK column) * allow inserting into a table using only the index * improve null handling of IfNull, fix output type of NewRowId * add NoResult nodes for branches which don't log a result, as a sanity check * add short-circuit to all logging operations * remove duplicate logging checks, and make logging enabled/disabled consistently depend on sqlx::explain instead of sqlx for capture & sqlx::explain for output * add failing test for awkwardly nested/filtered count subquery * handle special case of return operation to fix failing test * require trace log level instead of using whatever log level statement logging was configured to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track empty/non-empty/unknown-emptiness of cursors as part of the state. That enables Rewind/Last operations to filter which branch path to take (instead of always assuming both paths are potentially valid). Also updates Move/Copy to handle the use use of those opcodes against a range of registers.
Fixes #1923
Fixes #1979