Sqlite explain plan log efficiency #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the cleanup here, I may wait on merging #1946 until 0.7.0 because I'm not sure how it will interact with null inference but it's nice to get some kind of performance win anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce overhead of sqlite explain plan logging.
Partial fix for #1921
Very rough
`initial
real 3m26.159s
user 3m23.611s
sys 0m1.920s
capture program & operations by reference
real 3m7.704s
user 3m6.264s
sys 0m0.754s
use Vec instead of HashSet for results
real 1m24.922s
user 1m24.317s
sys 0m0.562s
check logging enabled before cloning result
real 1m17.668s
user 1m17.047s
sys 0m0.521s
`