Exposing the Oid of PostgreSQL types #2146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, is there anything else to do from my side? Is this something that could be merged? |
abonander
reviewed
Feb 2, 2023
| pub fn oid(&self) -> Oid { | ||
| self.0.oid() | ||
| } | ||
|
|
There was a problem hiding this comment.
This isn't a suitable way to expose this as the type OID may not be resolved yet, e.g. if self was constructed from PgTypeInfo::with_name() this will panic.
There was a problem hiding this comment.
Is there a suitable way of exposing the OID? If I want to deserialize a field to a different type depending on the column type, which could be the correct approach?
|
Closing due to inactivity. Feel free to reopen but please address the review comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1111. It adds a function to retrieve OIDs, which is very useful in very dynamic schemas, such as DBMSs or when you want to provide a more low-level interface to the DB.