sqlite date macro support

[Arcayr]

Adds DATE pseudo-type support for sqlite into the macros for both chrono and time.

Just adding the few lines mentioned in #2026 (comment).

I'm aware sqlite has no actual support for the types and simply treats them as strings, however given we already kinda support it in sqlx I figured it may as well be integrated.

[abonander]

@Arcayr please address CI failures.

[Arcayr]

All checks passed now. Thanks!

[Arcayr]

I've actually noticed that this breaks applications relying on serialising time, and probably in a couple of other ways, due to the compiler trying to turn all time types from OffsetDateTime into PrimitiveDateTime.

Switching the entries around in the file modified in the original PR fixes it. I haven't poked deep enough into the sqlx macro generation to work out why. If anyone has a pointer for a fix I can get it incorporated.

[abonander]

@Arcayr it's pretty dumb: it just tries the types in order and checks https://docs.rs/sqlx/latest/sqlx/trait.Type.html#method.compatible

So if you place the new entry before another compatible type, it will take precedent.

Since SQLite doesn't have dedicated data types for dates and times, we use the string of the declared column type:

sqlx/sqlx-sqlite/src/type_info.rs

Line 94 in 253d8c9

"date" => DataType::Date,

[Arcayr]

@Arcayr it's pretty dumb: it just tries the types in order and checks https://docs.rs/sqlx/latest/sqlx/trait.Type.html#method.compatible

I thought that was the case but didn't want to presume, I haven't been around Rust code long enough yet. :)

So if you place the new entry before another compatible type, it will take precedent.
Since SQLite doesn't have dedicated data types for dates and times, we use the string of the declared column type:

sqlx/sqlx-sqlite/src/type_info.rs

Line 94 in 253d8c9

"date" => DataType::Date,

In this case, I imagine it'd be fine just using OffsetDateTime instead of PrimitiveDateTime, as you get conversion issues the other way. I'll update the PR accordingly and rebase if you agree.

(One alternative would perhaps be to use something like datetimetz, similar to Postgres's timestamptz, but that'd be departing even further from the fact that SQLite doesn't have native date/time support.)

[Arcayr]

I ended up switching them, as OffsetDateTime is a superset of PrimitiveDateTime in all senses anyway. This should be ready to merge if you're happy with it. Thanks!

[abonander]

Changing the order of existing declarations is technically a breaking change but in this case it makes sense.