Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require db url for prepare #2882

Merged

Conversation

tamasfe
Copy link
Contributor

@tamasfe tamasfe commented Nov 17, 2023

Continuation of #2675, since I didn't have permission to reopen that PR.

I've rebased and restored the eager connection checks when DATABASE_URL is provided.

@abonander
Copy link
Collaborator

I didn't realize that the PR author wouldn't be able to reopen it if I closed it. I wonder if that's in the settings somewhere.

@abonander abonander merged commit d3a28d4 into launchbadge:main Nov 21, 2023
64 checks passed
@tamasfe tamasfe deleted the prepare/do-not-always-require-db-url branch November 21, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants