feat: expose getters for connect options fields #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes some of the main fields for PgConnectOptions and MySqlConnectOptions. Exposed fields include: host, port, socket, ssl mode, application name, and charset.
saiintbrisson
changed the title
kukabi
pushed a commit
to helikon-labs/sqlx
that referenced
this pull request
Feb 22, 2024
Exposes some of the main fields for PgConnectOptions and MySqlConnectOptions. Exposed fields include: host, port, socket, ssl mode, application name, and charset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes some of the main fields for PgConnectOptions and
MySqlConnectOptions. Exposed fields include host, port, socket,
ssl mode, application name, and charset via getters.
It didn't seem like a good idea to expose passwords and SSL certificates.
Other less relevant fields also don't look necessary.
Partially solves #2764 by creating getters for most fields.