Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Nagios::CheckLogfiles::Search::Eventlog only if we are on Windows. #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hpreusse
Copy link

No description provided.

@hpreusse
Copy link
Author

This PR should addess parts of #73

@xavierba
Copy link

Thanks for submitting the PR. Actually, you should use 'require' rather than 'use', so Nagios::CheckLogfiles::Search::Eventlog isn't used at compile time, only runtime.
Sorry for commenting too early yesterday, I probably was too low on caffeine ;)

@hpreusse
Copy link
Author

@xavierba. I'm not a programmer at all, I just moved some code around. I've changed the fork and hence updated the PR. Thanks for the hint!

@lausser
Copy link
Owner

lausser commented Jul 3, 2023

I am aware of your comments here and i will have a look later. I'm just too busy in the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants