Refactoring py/ports #131
Merged
Refactoring py/ports #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass and removed anonymous argument list for their init functions
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
reviewed
Feb 13, 2022
phstratmann
requested changes
Feb 13, 2022
There was a problem hiding this comment.
I have only reviewed the documentation. In general, a great job, Philipp!
There were a few places where I felt that a reformulation or more information could make things clearer to a newcomer. These points are added to the file changes as conversations. Let me know if you have any questions!
awintel
approved these changes
Feb 15, 2022
phstratmann
reviewed
Feb 16, 2022
phstratmann
requested changes
Feb 16, 2022
phstratmann
approved these changes
Feb 16, 2022
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* - refactor creation of ImplicitVarPort into a common function * - refactor creation of ImplicitVarPort into a common function * - refactor inheritage of PyInPort and PyOutPort to a common parent class and removed anonymous argument list for their init functions * - Adressed requested changes of PR (rename of class, adding comments) * - fix unit tests - try resolving conflict * - Adressed requested changes of PR (adding comments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the creation of implicit var ports into a common function in the RefPort class, which can be used by the compiler or elsewhere in the future.
Refactored inheritance of PyInPorts and PyOutPorts to a common IO parent class and removed the anonymous argument list in the init function. (Issue #84)