Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OGG metadata extraction #101

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Fix OGG metadata extraction #101

merged 1 commit into from
Apr 27, 2024

Conversation

devoxin
Copy link
Member

@devoxin devoxin commented Apr 27, 2024

  • Normalise tag names as uppercase so that tag names such as "title", "Title", "TiTlE" etc still match as "TITLE". Same for artist.
  • Use boxed length variable to avoid NullPointerException if length extraction fails.

@devoxin devoxin merged commit 588b0ad into main Apr 27, 2024
1 check passed
@devoxin devoxin deleted the fix-ogg-metadata-extraction branch April 27, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topi314 topi314 topi314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devoxin @topi314