Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parameter prefixes in ThermalZones.Detailed #2555

Closed
perost opened this issue Jun 28, 2021 · 3 comments · Fixed by #2558
Closed

Missing parameter prefixes in ThermalZones.Detailed #2555

perost opened this issue Jun 28, 2021 · 3 comments · Fixed by #2558
Assignees
@JayHuLBL

Comments

@perost
Copy link
Contributor

perost commented Jun 28, 2021

The following components are used as parameters but are not declared as such:

modelica-buildings/Buildings/ThermalZones/Detailed/Validation/BESTEST/Cases6xx/Case600FF.mo

Lines 151 to 155 in dd3df91

Buildings.ThermalZones.Detailed.Validation.BESTEST.Data.Win600 window600(
UFra=3,
haveExteriorShade=false,
haveInteriorShade=false) "Window"
annotation (Placement(transformation(extent={{40,84},{54,98}})));

modelica-buildings/Buildings/ThermalZones/Detailed/FLEXLAB/Rooms/X3B/Electrical.mo

Lines 28 to 31 in dd3df91

replaceable
Data.Constructions.OpaqueConstructions.ExteriorConstructions.Construction3
eleExt "Construction describing the exterior walls in the electrical room"
annotation (Placement(transformation(extent={{430,-210},{450,-190}})));

@JayHuLBL JayHuLBL self-assigned this Jun 28, 2021
JayHuLBL added a commit that referenced this issue Jun 28, 2021
@JayHuLBL
corrected component declaration in BESTEST class #2555 [ci skip]
15b9cea
JayHuLBL added a commit that referenced this issue Jun 28, 2021
@JayHuLBL
corrected component declaration in FLEXLAB class #2555 [ci skip]
44a161c
@JayHuLBL JayHuLBL mentioned this issue Jun 28, 2021
Merged
JayHuLBL added a commit that referenced this issue Jun 28, 2021
@JayHuLBL
corrected declarations #2555, #2556
fa54349
JayHuLBL added a commit that referenced this issue Jun 28, 2021
@JayHuLBL
corrected declarations #2555, #2556
8b23f46
mwetter pushed a commit that referenced this issue Jul 12, 2021
@JayHuLBL
Fixed undeclared parameters (#2558)
c3a5475 
* corrected component declaration in BESTEST class #2555 [ci skip]

* corrected component declaration in FLEXLAB class #2555 [ci skip]

* added undeclared parameters, #2556 [ci skip]

* dummy commit to kick off CI test #2556
@perost perost mentioned this issue Sep 9, 2021
Closed
@casella
Copy link
Contributor

casella commented Sep 16, 2021

@JayHuLBL, @mwetter, please cherry-pick this commit into maint/7.0.x and maint/8.0.x branches, otherwise it won't be possible to use the library with OpenModelica.

@perost
Copy link
Contributor Author

perost commented Sep 17, 2021

@JayHuLBL, @mwetter, please cherry-pick this commit into maint/7.0.x and maint/8.0.x branches, otherwise it won't be possible to use the library with OpenModelica.

It's already done. It seems we also now test maint/7.0.x, see this report.

@casella
Copy link
Contributor

casella commented Sep 17, 2021

I had checked the commits of the maint/7.0.x but I could not identify it. Now I see it on 29 June, I just had to search for the right commit SHA...

Case600FF now passes the frontend, see maint report, so I confirm all's fine.

Case closed 😄

@perost perost mentioned this issue Oct 13, 2021
Closed
mildwall added a commit to mildwall/modelica-buildings that referenced this issue Sep 16, 2024
@mildwall
Fixed undeclared parameters (lbl-srg#2558)
c98d0eb 
* corrected component declaration in BESTEST class lbl-srg#2555 [ci skip]

* corrected component declaration in FLEXLAB class lbl-srg#2555 [ci skip]

* added undeclared parameters, lbl-srg#2556 [ci skip]

* dummy commit to kick off CI test lbl-srg#2556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayHuLBL JayHuLBL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed undeclared parameters lbl-srg/modelica-buildings
3 participants
@casella @perost @JayHuLBL