Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation of VAVReheat models #2600

Closed
mwetter opened this issue Sep 3, 2021 · 0 comments · Fixed by #2601
Closed

Correct documentation of VAVReheat models #2600

mwetter opened this issue Sep 3, 2021 · 0 comments · Fixed by #2601
Assignees

Comments

@mwetter
Copy link
Member

mwetter commented Sep 3, 2021

The VAVReheat model uses the base class Buildings.Examples.VAVReheat.BaseClasses.PartialOpenLoop. This base class implements a replaceable model that contains the structure of the envelope model. PartialOpenLoop states that this model is representative for the medium office building. However, this description should be done in the actual implementation of the medium office model, rather than in PartialOpenLoop, in particular because PartialOpenLoop is also used in the Spawn examples which replace the model with a small office building.

@mwetter mwetter self-assigned this Sep 3, 2021
mwetter added a commit that referenced this issue Sep 3, 2021
mwetter added a commit that referenced this issue Sep 3, 2021
mwetter added a commit that referenced this issue Sep 4, 2021
* Updated documentation for #2600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant