Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cooling coil model #2560

Merged
merged 25 commits into from
Jul 20, 2021
Merged

Replace cooling coil model #2560

merged 25 commits into from
Jul 20, 2021

Conversation

AntoineGautier
Copy link
Contributor

This closes #2549.

@AntoineGautier AntoineGautier changed the title Replace cooling coil model in example models Replace cooling coil model Jun 30, 2021
@AntoineGautier
Copy link
Contributor Author

Note that with the new cooling coil model, the models in Buildings/Examples/VAVReheat fail to simulate with JModelica. They have been excluded from the CI tests.

@JayHuLBL
Copy link
Contributor

JayHuLBL commented Jul 7, 2021

@AntoineGautier The changes are good to me, just need change back the .travis.yml.

@AntoineGautier
Copy link
Contributor Author

AntoineGautier commented Jul 13, 2021

TODO before merging:

  • Update cooling FCU models in Buildings.Experimental.DHC.Loads with the new coil model

@JayHuLBL Sorry I forgot to update those models. This is done down. Could you please review the last commits?

@AntoineGautier
Copy link
Contributor Author

@JayHuLBL This issue with OCT is fixed with d70513e.
I also added a start value for an iteration variable that the wet coil model introduces when configured in steady state, see 237bca2.
This is ready to merge if you are fine with those changes.

@mwetter mwetter self-assigned this Jul 16, 2021
@JayHuLBL
Copy link
Contributor

@AntoineGautier The changes look good to me.

@mwetter mwetter merged commit 4867dd7 into master Jul 20, 2021
@mwetter mwetter deleted the issue2549_newCoilModel branch July 20, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cooling coil model
3 participants