Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lit-tests: Prevent hangs via a one-minute time-out for individual tests #4682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kinke
Copy link
Member

@kinke kinke commented Jun 8, 2024

No description provided.

@kinke
Copy link
Member Author

kinke commented Jun 8, 2024

@rainers: Sorry mate, we'd need your help again for msvc_eh_terminate() adaptations with MSVC v17.10, x64 only. libcmt seems fine, libcmtd broke. No results for the dynamic variants yet, will update this comment as CI results come in.

Edit: msvcrtd is broken too, but the release one fortunately still works too. So only both x64 debug variants broke.

@rainers
Copy link
Contributor

rainers commented Jun 10, 2024

Hi @kinke, please try this one: #4683

Unfortunately, lit requires the `psutil` pip package for that functionality.
@kinke kinke changed the title Investigate Win64 regression (hanging lit-tests) with latest GHA image (MSVC 17.9 => 17.10) lit-tests: Prevent hangs via a one-minute time-out for individual tests Jun 12, 2024
@kinke kinke marked this pull request as ready for review June 13, 2024 13:37
@kinke
Copy link
Member Author

kinke commented Jun 13, 2024

A bit of a pity that lit needs an extra psutil pip package for this functionality. And hardcoding a time-out isn't ideal either, but I assume 60 secs is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants