refactor: port mistletoe + MathJax changes from doc-gen #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryangingechen
commented
Feb 14, 2021
| ```latex | ||
| You can use LaTeX using `$$` to enclose inline LaTeX and | ||
| ````md | ||
| ```math |
There was a problem hiding this comment.
This, at least, was wrong previously.
|
Is this consistent with |
It will be now that leanprover-community/doc-gen#110 is merged. (I will try to backport some of the MathJax related changes here next.) |
|
Actually, let me rework this more along the lines of leanprover-community/doc-gen#110. Namely, I want to see if I can factor out the markdown processing into another module like I did there. |
|
|
bryangingechen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the changes to the mistletoe CustomHTMLRenderer class from leanprover-community/doc-gen#110 that are needed to make it work well with MathJax:
CustomHTMLRenderercode tomistletoe_renderer.pymathjax_editing.py(only called bymistletoe_renderer)latex.md(will be viewable at https://leanprover-community.github.io/latex.html after this is deployed, but should not be linked to from anywhere else)One non-MathJax-related change in behavior in
CustomHTMLRendereris that the syntax highlighting now defaults tolean, rather than attempting to guess a language. This makes it agree with both Zulip anddoc-gen. I thus added info strings to the markdown files that needed them.