Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and fix theme token updates against KDS #11867

Closed
marcellamaki opened this issue Feb 13, 2024 · 1 comment
Closed

Audit and fix theme token updates against KDS #11867

marcellamaki opened this issue Feb 13, 2024 · 1 comment
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Feb 13, 2024

Overview

In support of planned patch 1, we need to ensure that our token mapping is properly upgraded, in particular where there are changes to the components token map (i.e. previously a primary token, but now needs to be the color of the secondary token).

To Do

Review Kolibri against KDS token updates (pending). Some updates may need to be made in KDS, and some may need to be made in Kolibri.
General areas of consideration:

  • App bar updates
  • learning activity icons
  • icons generally
  • hover states and active states

Search Kolibri codebase for:

  • references to tokens that are added in to custom components. Particularly primary and secondarytokens. Ask if there are any questions about which is the appropriate token going forward
  • Hex codes that do not belong

Manually review (you can ask for support from designers and Radina once you have a PR with assets):

  • Links and/or text with insufficient contrast (this would be edge cases)

@marcellamaki @jtamiace @tomiwaoLE and @radinamatic are available for support

@rtibbles
Copy link
Member

Fixed in #11867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

4 participants