[DO NOT MERGE, FOR QA ONLY] Test KSelect refactor #12079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Artifacts
|
|
Hi @MisRob the only issue I was able to identify is that most of the drop-downs are now opening upwards instead of downwards: drop-downs.mp4 |
|
Thank you, @pcenov. I've just tried whether the issue is present on my rebrand PR which doesn't contain any KDS updates tested in this PR and the bug is there too. So I think it's either caused by some recent KDS releases or perhaps it was there even before. I will report as separate issue.
|
|
^ Above issue reported here learningequality/kolibri-design-system#690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
learningequality/kolibri-design-system#549 introduces internal
KSelectrefactor. I previewed a few places in Kolibri, but it's a significant refactoring so @pcenov could you please do a more thorough test run of places in Kolibri where we use selects (https://design-system.learningequality.org/kselect/)?The main focus of QA at this point is just confirming that something major is not broken in regards to selects functionality. There's no need to report issues with colors, etc. because later I will merge rebrand work with this select work and there will be final test run.
Thanks so much.