Add optional padding argument to logo tool #12409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
DEV: backend
Build Artifacts
|
AllanOXDi
approved these changes
Sep 17, 2024
| @@ -34,6 +34,11 @@ def convert_svg_to_image( | |||
|
|
|||
| # Determine the dimensions for a square based on the cropped image | |||
| max_dim = max(img_cropped.size) | |||
|
|
|||
| if padding: | |||
| padding = int(padding) / 100 | |||
There was a problem hiding this comment.
None blocking, but I wonder if we could add some additional error handling to ensure that the padding value is a valid percentage (i.e. between 0 and 100). i.e. ensure that the padding value is within this range, and raising an error if it is not?
There was a problem hiding this comment.
We definitely could - as this was developer only code, I was not as thorough.
rtibbles
modified the milestones:
Kolibri 0.17: Planned Patch 2,
Kolibri 0.18: General maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary