-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating useSnackbar composable and replacing existing logic with it #12589
Conversation
adf0c23
to
24627da
Compare
Build Artifacts
|
Thank you for this @nathanaelg16 -- I'm going to give this a closer look early next week and test it out and I'm looking forward to it :) |
24627da
to
7cb1c00
Compare
fe066b9
to
ce1cc9b
Compare
I have taken a first look at this, and nothing raised any concerns. We just merged a PR up from release-v0.17.x which has caused a merge conflict, so if you could rebase and fix that, that would be great! |
3580787
to
47aeb05
Compare
47aeb05
to
c7418f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems correct, and very straight forward! I'll do a quick manual test to ensure there's nothing concerning here, but I don't see any reasons to think so from the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick manual QA of several affected places shows no regressions. This is good to go!
Excellent work again, @nathanaelg16 - this is very thorough and systematic! |
Summary
This change creates a new
useSnackbar
composable and migrates existing logic to use it.References
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)