Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating useSnackbar composable and replacing existing logic with it #12589

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

nathanaelg16
Copy link
Contributor

Summary

This change creates a new useSnackbar composable and migrates existing logic to use it.

References

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend labels Aug 22, 2024
@nucleogenesis
Copy link
Member

Thank you for this @nathanaelg16 -- I'm going to give this a closer look early next week and test it out and I'm looking forward to it :)

@github-actions github-actions bot added the APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) label Aug 23, 2024
@nathanaelg16 nathanaelg16 marked this pull request as ready for review August 23, 2024 22:12
@nathanaelg16 nathanaelg16 force-pushed the use_snackbar branch 2 times, most recently from fe066b9 to ce1cc9b Compare August 23, 2024 22:54
@rtibbles
Copy link
Member

I have taken a first look at this, and nothing raised any concerns.

We just merged a PR up from release-v0.17.x which has caused a merge conflict, so if you could rebase and fix that, that would be great!

@nathanaelg16 nathanaelg16 force-pushed the use_snackbar branch 2 times, most recently from 3580787 to 47aeb05 Compare August 26, 2024 17:02
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems correct, and very straight forward! I'll do a quick manual test to ensure there's nothing concerning here, but I don't see any reasons to think so from the code.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick manual QA of several affected places shows no regressions. This is good to go!

@rtibbles rtibbles merged commit cef47b7 into learningequality:develop Aug 28, 2024
34 checks passed
@rtibbles
Copy link
Member

Excellent work again, @nathanaelg16 - this is very thorough and systematic!

@nathanaelg16 nathanaelg16 deleted the use_snackbar branch August 28, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create composable for snackbar state and replace existing logic with it
3 participants