Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kolibri-design-system from 5.0.0-rc2 to 5.0.0-rc3 #12616

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 28, 2024

Bumps kolibri-design-system from 5.0.0-rc2 to 5.0.0-rc3.

Release notes

Sourced from kolibri-design-system's releases.

v5.0.0-rc3

What's Changed

KIcon

KCard

KThemePlugin

New components

Docs 🗒️

User experience

  • Updates $core-time value from 0.25s to 0.15s to get faster transitions in KButton, KExternalLink, KRouterLink, KModal, KCard, KIcon, KTabsList, KTabs, and places in consumers that imports $core-time. By @​MisRob in learningequality/kolibri-design-system#723.

New Contributors

Full Changelog: learningequality/kolibri-design-system@v5.0.0-rc2...v5.0.0-rc3

Changelog

Sourced from kolibri-design-system's changelog.

Changelog

Changelog is rather internal in nature. See release notes for the public overview and guidelines. Releases are recorded as git tags in the Github releases page.

Upcoming version 5.x.x (develop branch)

  • #753
    • Description: Bump KDS version to 5.0.0-rc3.
    • Products impact: -.
    • Addresses: -.
    • Components: -.
    • Breaking: -.
    • Impacts a11y: -.
    • Guidance: -.

#753: learningequality/kolibri-design-system#753

#741: learningequality/kolibri-design-system#751

  • #650
    • Description: Add KRadioButtonGroup component to fix keyboard navigation in radio button groups in Firefox
    • Products impact: New API
    • Addresses: learningequality/kolibri#10491
    • Components: KRadioButtonGroup
    • Breaking: no
    • Impacts a11y: yes
    • Guidance: Make sure that all KRadioButtons are wrapped in KRadioButtonGroup

#650: learningequality/kolibri-design-system#650

  • #723
    • Description: Updates $core-time value from 0.25s to 0.15s
    • Products impact: User experience - faster transitions
    • Addresses: Updates KDS to the latest guidance from the design team
    • Components: KButton, KExternalLink, KRouterLink, KModal, KCard, KIcon, KTabsList, KTabs, and places in consumers that imports $core-time
    • Breaking: no
    • Impacts a11y: no
    • Guidance: -

#723: learningequality/kolibri-design-system#723

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [kolibri-design-system](https://github.com/learningequality/kolibri-design-system) from 5.0.0-rc2 to 5.0.0-rc3.
- [Release notes](https://github.com/learningequality/kolibri-design-system/releases)
- [Changelog](https://github.com/learningequality/kolibri-design-system/blob/develop/CHANGELOG.md)
- [Commits](learningequality/kolibri-design-system@v5.0.0-rc2...v5.0.0-rc3)

---
updated-dependencies:
- dependency-name: kolibri-design-system
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added javascript Pull requests that update Javascript code TAG: dependencies Pull requests that update a dependency file labels Aug 28, 2024
@MisRob
Copy link
Member

MisRob commented Aug 28, 2024

Some contributors experience Can't resolve 'color' ... errors when yarn linking Studio and KDS, and the same issue happens with Kolibri's devserver-with-kds. I haven't yet got to try whether this happens when we install the new release in a standard way like here - just leaving note we'd better test it here before merging.

@MisRob
Copy link
Member

MisRob commented Aug 28, 2024

The PR that caused that is here learningequality/kolibri-design-system#728 and is part of this release

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes, and we know who to call if there are issues :)

@rtibbles rtibbles merged commit 2d88e0f into develop Aug 28, 2024
35 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/kolibri-design-system-5.0.0-rc3 branch August 28, 2024 14:59
@MisRob
Copy link
Member

MisRob commented Aug 28, 2024

Meanwhile it showed up it's just yarn link specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code TAG: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants