-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added text truncate in import channel dropdown #4186
added text truncate in import channel dropdown #4186
Conversation
Thanks @Jaspreet-singh-1032 for another contribution, this is very helpful |
} | ||
|
||
.text-truncate-ellipsis { | ||
max-width: 200px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LianaHarris360, Thanks for the review. I have some queries. Without setting fixed width this does not seem to work because using ellipsis
needs a specific width. What I am thinking is to pass a prop to the MultiSelect
component that whether it should use ellipsis or not and if yes then what should be the max-width
Let me know if you have any other suggestions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jaspreet-singh-1032 Good idea, that sounds like it should work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes all make sense and it looks great!
Summary
Fixes #4166
Screenshots (if applicable)
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)