Skip to content

Commit

Permalink
Upgraded .NET7 dependency to Umbraco v11.0.0-rc6
Browse files Browse the repository at this point in the history
Reverted the previous breaking-change.
umbraco/Umbraco-CMS#13489 (comment)
  • Loading branch information
leekelleher committed Nov 29, 2022
1 parent 6a5bfa7 commit a66a1f1
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 29 deletions.
4 changes: 2 additions & 2 deletions build/manifest-nuget-core.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
<dependency id="Umbraco.Cms.Web.BackOffice" version="[10.0.0, 13.0.0)" />
</group>
<group targetFramework="net7.0">
<dependency id="Umbraco.Cms.Web.Website" version="[11.0.0, 13.0.0)" />
<dependency id="Umbraco.Cms.Web.BackOffice" version="[11.0.0, 13.0.0)" />
<dependency id="Umbraco.Cms.Web.Website" version="[11.0.0-rc6, 13.0.0)" />
<dependency id="Umbraco.Cms.Web.BackOffice" version="[11.0.0-rc6, 13.0.0)" />
</group>
</dependencies>
</metadata>
Expand Down
2 changes: 1 addition & 1 deletion src/Umbraco.Cms.11.x/Umbraco.Cms.11.x.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Umbraco.Cms" Version="11.0.0-rc5" />
<PackageReference Include="Umbraco.Cms" Version="11.0.0-rc6" />
<PackageReference Include="uSync" Version="11.0.0-rc3" />
<ProjectReference Include="..\Umbraco.Community.Contentment\Umbraco.Community.Contentment.csproj" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,7 @@ public EditorNotesConfigurationConnector(
_macroParser = macroParser;
}

#if NET7_0
public object FromArtifact(IDataType dataType, string configuration, IContextCache contextCache)
#else
public object FromArtifact(IDataType dataType, string configuration)
#endif
{
var dataTypeConfigurationEditor = dataType.Editor.GetConfigurationEditor();

Expand All @@ -70,11 +66,7 @@ public object FromArtifact(IDataType dataType, string configuration)
return db;
}

#if NET7_0
public string ToArtifact(IDataType dataType, ICollection<ArtifactDependency> dependencies, IContextCache contextCache)
#else
public string ToArtifact(IDataType dataType, ICollection<ArtifactDependency> dependencies)
#endif
{
if (dataType.Configuration is Dictionary<string, object> config &&
config.TryGetValueAs(EditorNotesConfigurationEditor.Message, out string notes) == true &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,7 @@ public NotesConfigurationConnector(
_macroParser = macroParser;
}

#if NET7_0
public object FromArtifact(IDataType dataType, string configuration, IContextCache contextCache)
#else
public object FromArtifact(IDataType dataType, string configuration)
#endif
{
var dataTypeConfigurationEditor = dataType.Editor.GetConfigurationEditor();

Expand All @@ -70,11 +66,7 @@ public object FromArtifact(IDataType dataType, string configuration)
return db;
}

#if NET7_0
public string ToArtifact(IDataType dataType, ICollection<ArtifactDependency> dependencies, IContextCache contextCache)
#else
public string ToArtifact(IDataType dataType, ICollection<ArtifactDependency> dependencies)
#endif
{
if (dataType.Configuration is Dictionary<string, object> config &&
config.TryGetValueAs(NotesConfigurationField.Notes, out string notes) == true &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,14 @@ public RenderMacroConfigurationConnector(IConfigurationEditorJsonSerializer conf
_configurationEditorJsonSerializer = configurationEditorJsonSerializer;
}

#if NET7_0
public object FromArtifact(IDataType dataType, string configuration, IContextCache contextCache)
#else
public object FromArtifact(IDataType dataType, string configuration)
#endif
{
var dataTypeConfigurationEditor = dataType.Editor.GetConfigurationEditor();

return dataTypeConfigurationEditor.FromDatabase(configuration, _configurationEditorJsonSerializer);
}

#if NET7_0
public string ToArtifact(IDataType dataType, ICollection<ArtifactDependency> dependencies, IContextCache contextCache)
#else
public string ToArtifact(IDataType dataType, ICollection<ArtifactDependency> dependencies)
#endif
{
if (dataType.Configuration is Dictionary<string, object> config &&
config.TryGetValueAs(RenderMacroConfigurationEditor.Macro, out JArray array) == true &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">
<PackageReference Include="Umbraco.Cms.Web.Website" Version="11.0.0-rc5" />
<PackageReference Include="Umbraco.Cms.Web.BackOffice" Version="11.0.0-rc5" />
<PackageReference Include="Umbraco.Cms.Web.Website" Version="11.0.0-rc6" />
<PackageReference Include="Umbraco.Cms.Web.BackOffice" Version="11.0.0-rc6" />
</ItemGroup>

<Target Name="RemoveLuceneAnalyzer" BeforeTargets="CoreCompile">
Expand Down

0 comments on commit a66a1f1

Please sign in to comment.