fix: dismiss open bot loading screen (microsoft#5290)

* fix: dismiss open bot loading screen * minor Co-authored-by: Soroush <hatpick@gmail.com>
lei9444 · Dec 10, 2020 · f085d22 · f085d22
1 parent baa80e8
commit f085d22
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Composer/packages/client/src/recoilModel/dispatchers/project.ts b/Composer/packages/client/src/recoilModel/dispatchers/project.ts
@@ -246,7 +246,6 @@ export const projectDispatcher = () => {
         if (navigate) {
           navigateToBot(callbackHelpers, projectId, mainDialog);
         }
-        set(botOpeningState, false);
 
         if (typeof callback === 'function') {
           callback(projectId);
@@ -256,6 +255,7 @@ export const projectDispatcher = () => {
         removeRecentProject(callbackHelpers, path);
         handleProjectFailure(callbackHelpers, ex);
         navigateTo('/home');
+      } finally {
         set(botOpeningState, false);
       }
     }

diff --git a/Composer/packages/server/src/services/telemetry.ts b/Composer/packages/server/src/services/telemetry.ts
@@ -69,7 +69,7 @@ if (instrumentationKey) {
 
       // remove PII
       for (const property of piiProperties) {
-        if (data.baseData.properties[property]) {
+        if (data.baseData.properties[property] !== undefined) {
           delete data.baseData.properties[property];
         }
       }