Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KubeJsonApi.forCluster missing from extension API and remove class constructors that require dependencies #6947

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Jan 16, 2023

  • Make sure that dependency constructors are not exported
  • Readd KubeJsonApi.forCluster

Signed-off-by: Sebastian Malton sebastian@malton.name

- Make sure that dependency constructors are not exported
- Readd `KubeJsonApi.forCluster`

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added bug Something isn't working area/extension Something to related to the extension api labels Jan 16, 2023
@Nokel81 Nokel81 added this to the 6.4.0 milestone Jan 16, 2023
@Nokel81 Nokel81 requested a review from a team as a code owner January 16, 2023 14:47
@Nokel81 Nokel81 requested review from ixrock and aleksfront and removed request for a team January 16, 2023 14:47
} from "../../common/k8s-api/kube-json-api";

function KubeJsonApiCstr(config: JsonApiConfig, reqInit?: RequestInit) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Cstr stand for Constructor? Maybe avoid abbreviation for clarity?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that function isn't exposed to the extension API at all. Just an an internal implementation to this file.

@Nokel81 Nokel81 merged commit 5c9dc03 into master Jan 16, 2023
@Nokel81 Nokel81 deleted the fix-KubeJsonApi branch January 16, 2023 15:04
@Nokel81 Nokel81 mentioned this pull request Jan 18, 2023
@Nokel81 Nokel81 changed the title Fix extension API Fix KubeJsonApi.forCluster missing from extension API and remove class constructors that require dependencies Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extension Something to related to the extension api bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants