More reliable content loading #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the height of the headless browser to 20000 pixels so no scrolling is needed for all content to load. This fixes a problem when some content in the middle of the screen would not be loaded. Also adds additional signal for the page load check that looks for any changes in the page source. This fixes a situation where `notion-scroller` already has some children but not all content has been loaded yet.
This was referenced Mar 29, 2022
leoncvlt
approved these changes
Apr 3, 2022
divyaeM
referenced
this pull request
in divyaeM/notion-to-html
Jun 3, 2023
More reliable content loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the height of the headless browser to 20000 pixels so no
scrolling is needed for all content to load.
This fixes a problem when some content in the middle of the screen would
not be loaded.
Also adds additional signal for the page load check that looks for any
changes in the page source. This fixes a situation where
notion-scrolleralready has some children but not all contenthas been loaded yet.