Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak: defer import of slow Llava* classes #908

Merged
merged 1 commit into from
Sep 10, 2024
Merged

tweak: defer import of slow Llava* classes #908

merged 1 commit into from
Sep 10, 2024

Conversation

leondz
Copy link
Owner

@leondz leondz commented Sep 10, 2024

i don't want to spend any more of my life waiting for these to load during dev

longer-term things to address:

  • don't speculatively load torch or Image either
  • move HFCompatible out ~~~to the ether~~~ so that generators.base no longer has from garak.generators.huggingface import HFCompatible

@leondz leondz added the generators Interfaces with LLMs label Sep 10, 2024
@jmartin-tech jmartin-tech merged commit b37920b into main Sep 10, 2024
10 checks passed
@jmartin-tech jmartin-tech deleted the feature/llavalazy branch September 10, 2024 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmartin-tech jmartin-tech jmartin-tech approved these changes

Assignees
No one assigned
Labels
generators Interfaces with LLMs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leondz @jmartin-tech