Fix window environment channel closing bug (#28)

leonwind · May 5, 2022 · 4458735 · 4458735
1 parent 4f0aa27
commit 4458735
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/cli/cli2cloud/cli2cloud.go b/cli/cli2cloud/cli2cloud.go
@@ -70,6 +70,7 @@ func sendPipedMessages(c proto.Cli2CloudClient, ctx context.Context, password *s
 
 	// Create a messages stream which is reading from both Stdout and Stdin
 	streamMessages := make(chan string)
+	defer close(streamMessages)
 	go streams.CreateStreams(streamMessages)
 
 	for row := range streamMessages {

diff --git a/cli/cli2cloud/streams/collectStreams.go b/cli/cli2cloud/streams/collectStreams.go
@@ -11,8 +11,6 @@ func readFromStreams(messages chan string, f *os.File) {
 		row := scanner.Text()
 		messages <- row
 	}
-
-	close(messages)
 }
 
 func CreateStreams(messages chan string) {