Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix list of scopes in app integrations #631

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

jorgeajimenezl
Copy link
Contributor

@jorgeajimenezl jorgeajimenezl commented Feb 23, 2024

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@jorgeajimenezl jorgeajimenezl changed the title fix: Fix list of scopes in app integration fix: Fix list of scopes in app integrations Feb 23, 2024
Copy link

@codespearhead codespearhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the proposed changes, as they provide a safeguard against raising an AttributeError when scope is an iterable instead of a string. However, I can't think of a case where that will ever happen.

So LGTM.

However, here's how to make it better:

As for the PR itself:

  1. Squash commits 7beb8f6 and 96c8449 into a single commit.
  2. Changing "openid" to 'openid' deviates from the consistent style of strings in the file and is unrelated to the PR, thus this specific change shouldn't have been included.

These changes will make it much easier to review the PR. For more information, please refer to Keycloak's PR checklist [1][2].

[1] https://github.com/keycloak/keycloak/blob/main/CONTRIBUTING.md#submitting-your-pr
[2] https://github.com/keycloak/keycloak/blob/main/CONTRIBUTING.md#contributing-to-keycloak

@lepture lepture merged commit 11f13e4 into lepture:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants