Support specifying custom variables when calling lessc and less.js. #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both lessc and less.js can now be provided with global variables that all .less files will have immediate access to. This can be used to provide, for example, a base path for an @import, signed URLs offering temporary access to an image on S3, or anything else. lessc has two new parameters, --global-var and --modify-var. Both take a value of the form "varname=value". --global-var declares variables immediately before the content of the .less files, and --modify-var declares them after. --global-var is used when rules, imports, or other variables will depend on the provided variable. --modify-var is used to override a variable declared within the .less file. less.js's equivalent for global variables is less.globalVars. This can be set before loading less.js. There is no new requivalent to --modify-var, as less.modifyVars can be used for that purpose.
|
👍 |
| @@ -64,7 +71,7 @@ args = args.filter(function (arg) { | |||
| return false; | |||
| } | |||
|
|
|||
| if (match = arg.match(/^--?([a-z][0-9a-z-]*)(?:=([^\s]*))?$/i)) { arg = match[1] } | |||
| if (match = arg.match(/^--?([a-z][0-9a-z-]*)(?:=(.*))?$/i)) { arg = match[1] } | |||
There was a problem hiding this comment.
whats the meaning of this change? so it goes from all non whitespace to characters?
There was a problem hiding this comment.
Yeah, it's to allow for whitespace characters. Otherwise, it's not possible to do expressions or any other sort of content containing whitespace. The whitespace will only end up in the value if explicitly quoted on the shell.
I looked through the other command line arguments and didn't see any that seemed they would be impacted by this change, and sys.argv already handles whitespace between arguments. I may have missed something important though.
|
👍 !!! |
lukeapage
added a commit
that referenced
this pull request
Nov 15, 2013
Support specifying custom variables when calling lessc and less.js.
This was referenced Nov 20, 2013
|
Doh! Again wrong number... Sorry! |
|
@lukeapage ping, I'd love to see this moved into less.js core. Can you give pointers for a PR? |
This was referenced Feb 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both lessc and less.js can now be provided with global variables that
all .less files will have immediate access to. This can be used to
provide, for example, a base path for an
@import, signed URLs offeringtemporary access to an image on S3, or anything else.
lessc has two new parameters,
--global-varand--modify-var. Both takea value of the form
"varname=value".--global-vardeclares variablesimmediately before the content of the .less files, and
--modify-vardeclares them after.
--global-varis used when rules, imports, or other variables will dependon the provided variable.
--modify-varis used to override a variable declared within the .lessfile.
less.js's equivalent for global variables is
less.globalVars. This canbe set before loading less.js. There is no new equivalent to
--modify-var, as less.modifyVars can be used for that purpose.Implements issue #731.