#1778 standardised using starting index, to fix incorrectly mapped sourcemaps #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of accurate source maps
|
Yes, I haven't had time to do proper tests so the current one only serves |
lukeapage
added a commit
that referenced
this pull request
Jan 11, 2014
#1778 standardised using starting index, to fix incorrectly mapped sourcemaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1778.
Appears that there is already convention to use the starting index for most of the nodes, just a couple had not implemented it correctly, or only half implemented it (ie. had index set but still used i). This fixes that to ensure consistency and produce correct sourcemaps.
It does break the sourcemap test because that test tests against a previously generated sourcemap which contains incorrect mappings, rookie testing error I'll leave that to the person that created the rookie test to fix.
Would suggest using http://sokra.github.io/source-map-visualization/ to test sourcemaps.