Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix import sequencing #2246

Merged
merged 14 commits into from
Oct 26, 2014
Merged

Attempt to fix import sequencing #2246

merged 14 commits into from
Oct 26, 2014

Commits on Oct 23, 2014

  1. Initial sketch-out (broken)

    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    8c89b26 View commit details
    Browse the repository at this point in the history

  2. Sequencer working so imports are always processed in the same order

    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    e793b17 View commit details
    Browse the repository at this point in the history

  3. when finding variables, look inside sub import nodes

    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    b4ae1e8 View commit details
    Browse the repository at this point in the history

  4. make sure an error is not lost

    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    5f09ee7 View commit details
    Browse the repository at this point in the history

  5. flatten import visitor so that variable imports can be processed at t… 

    …he end of a global queue
    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    c757bef View commit details
    Browse the repository at this point in the history

  6. Tidy Import Visitor arguments

    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    5913834 View commit details
    Browse the repository at this point in the history

  7. Tidy context stack into actual stack - no need for an array

    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    5931025 View commit details
    Browse the repository at this point in the history

  8. Refactor out the processing of the import, ready to be done asyncrono… 

    …usly
    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    59a165b View commit details
    Browse the repository at this point in the history

  9. Method for how it will work asyncronously (broken)

    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    ebdda84 View commit details
    Browse the repository at this point in the history

  10. test for final working

    @lukeapage
    lukeapage committed Oct 23, 2014
    Configuration menu
    Copy the full SHA
    bbb8f9a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2014

  1. Fix - for some reason the flattening done by the import visitor is re… 

    …quired
    @lukeapage
    lukeapage committed Oct 24, 2014
    Configuration menu
    Copy the full SHA
    5f1f091 View commit details
    Browse the repository at this point in the history

  2. sequencer logic for variable import

    @lukeapage
    lukeapage committed Oct 24, 2014
    Configuration menu
    Copy the full SHA
    5202a1f View commit details
    Browse the repository at this point in the history

  3. use structure to run variable imports last

    @lukeapage
    lukeapage committed Oct 24, 2014
    Configuration menu
    Copy the full SHA
    e1c28d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2014

  1. further test case

    @lukeapage
    lukeapage committed Oct 25, 2014
    Configuration menu
    Copy the full SHA
    793383e View commit details
    Browse the repository at this point in the history