Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3346 #3338 #3345 #3363

Merged
merged 5 commits into from
Jul 11, 2019
Merged

Fixes #3346 #3338 #3345 #3363

merged 5 commits into from
Jul 11, 2019

Conversation

matthew-dean
Copy link
Member

No description provided.

@matthew-dean matthew-dean mentioned this pull request Feb 27, 2019
Closed
@seven-phases-max
Copy link
Member

I can't see anything wrong with this changes. A neat implementation.
(Personally I would probably use a error msg like "Function argument is expected to be a color value" or something (words like "argument" or "evaluate" are scary for non-geeks), but it's just a matter of personal preferences I guess - it's fine as it is now).

@stale
Copy link

stale bot commented Jun 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 27, 2019
@matthew-dean matthew-dean merged commit 88e126b into less:master Jul 11, 2019
@matthew-dean matthew-dean deleted the each-fixes-2019 branch July 11, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinjuarez calvinjuarez Awaiting requested review from calvinjuarez

@seven-phases-max seven-phases-max Awaiting requested review from seven-phases-max

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew-dean @seven-phases-max